Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression window resize issues #3565

Closed
allanaaa opened this issue Feb 3, 2021 · 9 comments · Fixed by #3587
Closed

Expression window resize issues #3565

allanaaa opened this issue Feb 3, 2021 · 9 comments · Fixed by #3587
Assignees
@Mo-hamdy2000
Labels
expression preview ui Dialog where the evaluation of expressions can be previewed Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
3.5

Comments

@allanaaa
Copy link
Contributor

allanaaa commented Feb 3, 2021

When changing the browser window size, parts of the expression editor window do not resize.

Current Results

window-resize-problem

Not a big issue but perhaps it's an easy fix.

Versions

  • Operating System: Windows
  • Browser Version: Firefox
  • OpenRefine: 3.4.1
@allanaaa allanaaa added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Feb 3, 2021
@wetneb wetneb added expression preview ui Dialog where the evaluation of expressions can be previewed Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Feb 3, 2021
@wetneb
Copy link
Member

wetneb commented Feb 3, 2021

Yes, it's really annoying!

@wetneb wetneb added the Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. label Feb 3, 2021
@Mo-hamdy2000
Copy link
Contributor

Could I work on this issue ?

@wetneb
Copy link
Member

wetneb commented Feb 4, 2021

It's all yours!

@AhwiniMirajkar
Copy link

Can I work on this

@wetneb
Copy link
Member

wetneb commented Feb 4, 2021

@AhwiniMirajkar no, as you can see it is already assigned.

@KaranSingh1301
Copy link

@Mo-hamdy2000 hey, Are still working on this?

@Mo-hamdy2000
Copy link
Contributor

@Mo-hamdy2000 hey, Are still working on this?

@KaranSingh1301 Yes, I opened a pull request to be reviewed.

@Mo-hamdy2000
Copy link
Contributor

@wetneb I have made the required changes in the pull request, kindly could you review it ?

@wetneb wetneb linked a pull request Feb 20, 2021 that will close this issue
fix: Expression window resize #3587
Merged
@wetneb
Copy link
Member

wetneb commented Feb 20, 2021

Closed by #3587.

@wetneb wetneb closed this as completed Feb 20, 2021
@wetneb wetneb added this to the 3.5 milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mo-hamdy2000 Mo-hamdy2000

Labels
expression preview ui Dialog where the evaluation of expressions can be previewed Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

fix: Expression window resize Mo-hamdy2000/OpenRefine
5 participants
@wetneb @allanaaa @Mo-hamdy2000 @KaranSingh1301 @AhwiniMirajkar