Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BCE dates in Wikibase upload #3816

Closed
wetneb opened this issue Apr 15, 2021 · 4 comments · Fixed by #3843
Closed

Support BCE dates in Wikibase upload #3816

wetneb opened this issue Apr 15, 2021 · 4 comments · Fixed by #3843
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration
Milestone

Comments

@wetneb
Copy link
Member

wetneb commented Apr 15, 2021

The Wikibase extension does not currently let the user upload "negative" dates (in the Julian/Gregorian calendars).

The currently supported formats are documented here: https://www.wikidata.org/wiki/Wikidata:Tools/OpenRefine/Editing/Schema_alignment#Dates

Proposed solution

Introduce a new syntax for those dates. For instance -YYYY or YYYY BCE could be used. Both are supported by Wikibase's UI.

Alternatives considered

We already support setting arbitrary calendars so in theory users could just use a calendar whose origin is before the date they want to represent, but that's really complicated and Wikibase will not convert between calendars by itself.

Additional context

Requested on the mailing list:
https://groups.google.com/g/openrefine/c/nBLMNsq98k4

@wetneb wetneb added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. labels Apr 15, 2021
@wetneb
Copy link
Member Author

wetneb commented Apr 15, 2021

Marking as a good first issue since this is fairly self-contained: changes should be contained to this class and its corresponding test class:
https://github.com/OpenRefine/OpenRefine/blob/master/extensions/wikidata/src/org/openrefine/wikidata/schema/WbDateConstant.java

@loulankxh
Copy link
Contributor

Hi, sir. I want to have a try at this issue but I encountered a problem when I try to build, compile the wikidata extension before running the tests. The error message is "Failed to execute goal on project wikidata: Could not resolve dependencies for project org.openrefine:wikidata:jar:3.5-SNAPSHOT: org.openrefine:main:jar:tests:3.5-SNAPSHOT was not found in https://oss.sonatype.org/content/repositories/snapshots/ during a previous attempt." and the website "https://oss.sonatype.org/content/repositories/snapshots/" is permission denied. I have tried many mirrors to try to get the dependency wikidata jar, however none of them succeed for this problem. I wonder if you know some possible reasons. Thanks

@wetneb
Copy link
Member Author

wetneb commented Apr 23, 2021

Hi @loulankxh, thanks for giving this a try! Yes this is a known issue about our build setup. Have you tried mvn compile test-compile?

Is this a problem you have through some IDE? On the command-line I would recommend to use the refine wrapper with refine build.

@loulankxh
Copy link
Contributor

Thanks really! The problem has been solved and now I can run tests for the wikidata module successfully. I will continue to fix this issue.

loulankxh pushed a commit to loulankxh/OpenRefine that referenced this issue Apr 23, 2021
loulankxh pushed a commit to loulankxh/OpenRefine that referenced this issue Apr 24, 2021
loulankxh pushed a commit to loulankxh/OpenRefine that referenced this issue Apr 24, 2021
@wetneb wetneb linked a pull request Apr 24, 2021 that will close this issue
loulankxh pushed a commit to loulankxh/OpenRefine that referenced this issue Apr 24, 2021
loulankxh pushed a commit to loulankxh/OpenRefine that referenced this issue Apr 24, 2021
wetneb pushed a commit that referenced this issue Apr 24, 2021
@wetneb wetneb added this to the 3.5 milestone Apr 24, 2021
@wetneb wetneb mentioned this issue Apr 24, 2021
16 tasks
gitonthescene pushed a commit to gitonthescene/OpenRefine that referenced this issue May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants