Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit project tags does not work #3979

Closed
thadguidry opened this issue Jun 11, 2021 · 1 comment · Fixed by #4613
Closed

Edit project tags does not work #3979

thadguidry opened this issue Jun 11, 2021 · 1 comment · Fixed by #4613
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
3.6

Comments

@thadguidry
Copy link
Member

thadguidry commented Jun 11, 2021 •
edited
Loading

When hovering on tags on projects in the Project table there is a hover tip, "Edit project tags".
Clicking on a tag does nothing.

To Reproduce

Steps to reproduce the behavior:

  1. Click Open Project
  2. Then hover on some tags in the Tags column on list of projects
  3. Try to click on some tags to edit

Current Results

Clicking is not allowed. Not actually editable, but the hover text says so?

Expected Behavior

However I don't know if it truly is supposed to be clickable in that area to edit.
It might have been an oversight in PR #1357 or a change in Javascript or just now instead should say "Project tags"?
Good news is that clicking on "About" link and editing a projects set of tags within the metadata editor does still work that way.

Screenshots

image

Versions

  • Operating System: Windows 10
  • Browser Version: Firefox latest
  • JRE or JDK Version: JDK13
  • OpenRefine: OpenRefine 3.5 Beta1

Datasets

Additional context
@thadguidry thadguidry added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. localization anything to do with i18n Internationalization and I10n localization labels Jun 11, 2021
@wetneb wetneb removed the localization anything to do with i18n Internationalization and I10n localization label Jun 11, 2021
@thadguidry
Copy link
Member Author

thadguidry commented Jun 11, 2021 •
edited
Loading

@wetneb It is originally a localization problem I think? See the linked PR above. Reading this comment from you and Ettore, I guess they were clickable before in earlier versions of OpenRefine after the merge? Nope, doesn't appear to be the case...

Version Can Click?
3.0 Beta Not Clickable
3.1 Beta Not Clickable
3.2 Not Clickable

Interestly, cursor: pointer was assigned to the .project-tag style at some point.

@elebitzero elebitzero mentioned this issue Mar 12, 2022
Merged
@wetneb wetneb added this to the 3.6 milestone Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.6
Development

Successfully merging a pull request may close this issue.

Edit project tags tooltip elebitzero/OpenRefine
2 participants
@wetneb @thadguidry