Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the autosave period via refine.sh/bat on command line #4113

Closed
thadguidry opened this issue Aug 19, 2021 · 2 comments · Fixed by #4220
Closed

Allow changing the autosave period via refine.sh/bat on command line #4113

thadguidry opened this issue Aug 19, 2021 · 2 comments · Fixed by #4220
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Milestone

Comments

@thadguidry
Copy link
Member

thadguidry commented Aug 19, 2021

I have some large projects that require launching where I really need the autosave period to be closer to 60 minutes. I use a few Windows shortcuts on my desktop for some common large OpenRefine projects that I sometimes cross with, etc. The problem is that I cannot easily use the Windows shortcuts to launch these particular large OpenRefine projects because I cannot also save the shortcuts with a command line parameter to control the autosaving. I can only control autosaving period from the refine.ini file.

a custom refine.ini path also is not a parameter that can be passed to the refine.sh/bat which probably would be the best solution all around.

Proposed solution

allow passing a custom refine.ini path as a parameter for the refine.sh/bat launcher.
We already have in the scripts a "endConfigReading" section that could be re-used and parameterized for consuming a custom refine.ini path such as

refine /c C:\Users\thadg\bigfile_refine.ini

Alternatives considered

Additional context

@thadguidry thadguidry added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. labels Aug 19, 2021
tejasrbhat pushed a commit to tejasrbhat/OpenRefine that referenced this issue Oct 17, 2021
@tejasrbhat
Copy link
Member

@thadguidry I raised a PR for this. Can you please review it ?

@thadguidry
Copy link
Member Author

Tested with and without refine-dev.ini and it overrides perfectly when the /c config file path specified, just as expected. Nice job!

@wetneb wetneb added this to the 3.6 milestone Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants