Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollable div layer to Project metadata view to prevent cutoff of CLOSE button #4119

Closed
thadguidry opened this issue Aug 23, 2021 · 2 comments · Fixed by #4527
Closed
Assignees
Labels
Difficulty: Intermediate Identifies moderately challenging issues that require some experience and familiarity with project. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone

Comments

@thadguidry
Copy link
Member

Currently if values in the Project metadata editor are too large then the CLOSE button is not seen and clickable to users.

Current Results

If the length of values is too long in any of the keys, then sometimes the CLOSE button will be cutoff and hidden from a user preventing them from being able to close the Project metadata panel.

Expected Behavior

Provide 2 things:

  1. a scrollable div layer that can hold and scroll through all the key:value rows.
  2. while scrolling, keep the CLOSE button at the bottom, and the Key and Value header labeling at the top.

Screenshots

image

Versions

  • Operating System: Windows 10
  • Browser Version: Firefox
  • JRE or JDK Version: JDK15
  • OpenRefine: 3.5 beta1

Datasets

Additional context

Using Cypress support for Visual testing, ensure to add 1 Cypress test that can

  1. click edit on Title row and add lots of text into value input box and click OK.
  2. using a previously cropped baseline image of the lower left corner that includes the CLOSE button.
  3. compare that cropped baseline image with a clip region of the screen during test, such as example (adjust numbers as necessary)
  .toMatchImageSnapshot({
    clip: { x: 125, y: 870, width: 75, height: 50 },
  });
  1. assert that the CLOSE button is still displayed and seen
@thadguidry thadguidry added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Difficulty: Intermediate Identifies moderately challenging issues that require some experience and familiarity with project. labels Aug 23, 2021
@rachittiwari8562
Copy link
Contributor

I would like to work on this issue.

@rachittiwari8562
Copy link
Contributor

Is there any cypress visual test already implemented ? . I am unable to find it .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Intermediate Identifies moderately challenging issues that require some experience and familiarity with project. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
3 participants