Skip to content

Useless waiting time when creating new Wikibase items from OpenRefine #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wetneb opened this issue Oct 19, 2021 · 0 comments · Fixed by #4227
Closed

Useless waiting time when creating new Wikibase items from OpenRefine #4226

wetneb opened this issue Oct 19, 2021 · 0 comments · Fixed by #4227
Assignees
@wetneb
Labels
performance Improving the performance of the system (frontend or backend) Type: Bug Issues related to software defects or unexpected behavior, which require resolution. wikibase Related to wikidata/wikibase integration
Milestone
3.5

Comments

@wetneb
Copy link
Member

wetneb commented Oct 19, 2021

When uploading a batch of new items to Wikibase from OpenRefine, we have a long initial waiting time which is a spurious exponential backoff on an operation that does not fetch any items.

To Reproduce

Steps to reproduce the behavior:

  1. First, create a project with a Wikibase schema which does not edit any existing Wikibase items, only creates new ones
  2. Then, upload the project to Wikibase

Current Results

Observe the long waiting time before any edit is made (0% progress)

Expected Behavior

Immediate creation of new items.

Versions

  • Operating System: Linux
  • Browser Version: Firefox
  • JRE or JDK Version: 11
  • OpenRefine: master (3.6-SNAPSHOT)
@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. performance Improving the performance of the system (frontend or backend) wikibase Related to wikidata/wikibase integration labels Oct 19, 2021
@wetneb wetneb self-assigned this Oct 19, 2021
wetneb added a commit to wetneb/OpenRefine that referenced this issue Oct 19, 2021
@wetneb
Fix useless waiting time before creating items when uploading to Wiki…
489d4f8 
…base.

Checks that there is at least one item to fetch before attempting to fetch
anything.

Closes OpenRefine#4226.
@wetneb wetneb mentioned this issue Oct 19, 2021
Merged
@wetneb wetneb added this to the 3.5 milestone Oct 19, 2021
wetneb added a commit that referenced this issue Oct 22, 2021
@wetneb
Fix useless waiting time before creating items when uploading to Wiki…
6372f2d 
…base. (#4227)

Checks that there is at least one item to fetch before attempting to fetch
anything.

Closes #4226.
wetneb added a commit that referenced this issue Oct 22, 2021
@wetneb
Fix useless waiting time before creating items when uploading to Wiki…
2e990cd 
…base. (#4227)

Checks that there is at least one item to fetch before attempting to fetch
anything.

Closes #4226.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wetneb wetneb

Labels
performance Improving the performance of the system (frontend or backend) Type: Bug Issues related to software defects or unexpected behavior, which require resolution. wikibase Related to wikidata/wikibase integration
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

Fix useless waiting time before creating items when uploading to Wikibase wetneb/OpenRefine
1 participant
@wetneb