Duplicates facet does not escape its column name, resulting in an invalid GREL expression

[wetneb]

The code that generates the GREL expression for the Duplicates facet does not escape the name of the selected column.
If this name contains a single quote character, this results in an invalid GREL expression, hence the facet cannot be used as such.

To Reproduce

Steps to reproduce the behavior:

1. First, import the following CSV file:

Jane's column,Jack's column
foo,bar
hey,ho
hey,bar

2. Then, create a Duplicates facet on any of the column (using the column menu)

Current Results

The facet's GREL expression is invalid: facetCount(value, 'value', 'Jane's column') > 1.

Expected Behavior

The GREL expression should be valid, for instance facetCount(value, 'value', 'Jane\'s column') > 1 would work.

Versions

• Operating System: irrelevant
• Browser Version: irrelevant
• JRE or JDK Version: irrelevant
• OpenRefine: master

Additional context

Brought up on our mailing list: https://groups.google.com/g/openrefine/c/2ic5F0YGcbk

[thadguidry]

Hmm, but we have always allowed single or double quotes in the expressions, does that not help enough here?

[wetneb]

I do not know what you mean by "help enough" here :) what solution do you have in mind?

[thadguidry]

I meant switching to double quotes versus only using single quotes.

If the value includes single quotes, then double quote wrapping should work. Escaping wouldn't be needed.
If the value includes double quotes, then single quote wrapping should suffice. Escaping wouldn't be needed.
if the value included double and single quotes, then single quote wrapping with escaping would be the only way to avoid the error.

Currently with 3.5 beta 1

[wetneb]

Yes, so you cannot avoid escaping entirely. I am not sure if it is worth adding extra logic to choose between quote types, it is probably easier to stick to one syntax and always escape for it.

[thadguidry]

Agree. Just mentioning how things have worked since the beginning of our code.