Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific UI to edit different entity types in Wikibase manifest #4270

Closed
wetneb opened this issue Nov 4, 2021 · 0 comments · Fixed by #4681
Closed

Add specific UI to edit different entity types in Wikibase manifest #4270

wetneb opened this issue Nov 4, 2021 · 0 comments · Fixed by #4681
Assignees
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration
Milestone

Comments

@wetneb
Copy link
Member

wetneb commented Nov 4, 2021

Following #4268, we will be able to use the current Wikibase schema interface to edit any entity type that has statements and/or terms: for instance, Properties or MediaInfo entities.

One problem with this integration is that it will propose irrelevant fields in the Wikibase schema. For instance, if I am editing MediaInfo entities, the OpenRefine user interface will offer adding labels, descriptions and aliases. This is confusing, because MediaInfo entities only have captions (which are internally the same thing as labels). So, as long as the user does not try to add description or aliases on MediaInfo entities, they will be able to edit, but this is still very brittle (for instance, it would be quite natural to assume that the "captions" that MediaInfo entities have correspond to "descriptions" on Wikidata, and therefore mistakenly select "description" when wanting to add a caption).

Therefore, we want to be able to adapt the user interface depending on the type of entity that we are editing.
For instance, when editing MediaInfo entities, the user should only be provided with the following data import options:

  • captions
  • statements
  • wikitext

When editing items, the user should be provided with the following fields:

  • labels, descriptions and aliases
  • statements
  • sitelinks (not supported yet)

Proposed solution

Wikibase schemas currently consist of a list of item templates. Users can add more of these templates using the + add item button in the schema window.
We could replace this button by a few others:

  • + add item
  • + add mediainfo (or other user-facing term, I suspect MediaInfo is just an internal term)
  • + add property (if we want to add support for properties…)

Those buttons could be shown only for the entity types actually supported by the Wikibase instance (for instance it would not make sense to offer editing MediaInfo entities on Wikidata, and conversely you should not be able to edit items on Commons).

Then, based on the choice made by the user, we would be able to show an entity template whose fields match the entity type (as hinted above).

Alternatives considered

We could simply have an + add entity button and then let the user select the entity type as a particular field in the entity template (which would then control which other fields are visible).

Additional context

The UI choices for this task should be discussed with Lozana.

This task is part of #2144.

@wetneb wetneb added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. wikibase Related to wikidata/wikibase integration labels Nov 4, 2021
@wetneb wetneb self-assigned this Mar 28, 2022
@wetneb wetneb added this to the 3.6 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant