Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java test suite fails locally in some timezones due to Daylight Saving Time differences #4294

Closed
wetneb opened this issue Nov 13, 2021 · 0 comments · Fixed by #4295
Closed

Java test suite fails locally in some timezones due to Daylight Saving Time differences #4294

wetneb opened this issue Nov 13, 2021 · 0 comments · Fixed by #4295
Assignees
@wetneb
Labels
tests Improving test coverage and speed Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
3.6

Comments

@wetneb
Copy link
Sponsor Member

wetneb commented Nov 13, 2021 •
edited
Loading

Running ./refine test on the master branch currently fails for me.

This is due to the fact that our date parsing code translates java Date objects to Java 8 OffsetDateTime in an incorrect way.

To Reproduce

Steps to reproduce the behavior:

  1. Add -Duser.timezone=CET to your Java test settings in pom.xml (<argLine>@{surefireArgs} -Dfile.encoding=cp1252 -Duser.timezone=CET</argLine>)
  2. Run ./refine test

Current Results

Test failures due to date parsing in importers.

Expected Behavior

No test failures.

Screenshots

Versions

  • Operating System: Debian
  • JRE or JDK Version: 11
  • OpenRefine: master branch
@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. tests Improving test coverage and speed labels Nov 13, 2021
@wetneb wetneb self-assigned this Nov 13, 2021
@wetneb wetneb mentioned this issue Nov 13, 2021
Merged
@wetneb wetneb added this to the 3.6 milestone Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wetneb wetneb

Labels
tests Improving test coverage and speed Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.6
Development

Successfully merging a pull request may close this issue.

Fix date parsing to avoid offsets due to DST. wetneb/OpenRefine
1 participant
@wetneb