Skip to content

Java test suite fails locally in some timezones due to Daylight Saving Time differences #4294

@wetneb

Description

@wetneb

Running ./refine test on the master branch currently fails for me.

This is due to the fact that our date parsing code translates java Date objects to Java 8 OffsetDateTime in an incorrect way.

To Reproduce

Steps to reproduce the behavior:

  1. Add -Duser.timezone=CET to your Java test settings in pom.xml (<argLine>@{surefireArgs} -Dfile.encoding=cp1252 -Duser.timezone=CET</argLine>)
  2. Run ./refine test

Current Results

Test failures due to date parsing in importers.

Expected Behavior

No test failures.

Screenshots

Versions

  • Operating System: Debian
  • JRE or JDK Version: 11
  • OpenRefine: master branch

Metadata

Metadata

Assignees

Labels

Type: BugIssues related to software defects or unexpected behavior, which require resolution.testsImproving test coverage and speed

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions