CSV importer: confusing behaviour of checkboxes

[wetneb]

In the configuration options for the CSV/TSV importer, two checkboxes are linked as if one of them had to be checked.

This is a bad pattern: if those checkboxes are really meant to be grouped, then they should be radio buttons and be positioned next to each other.

To Reproduce

Steps to reproduce the behavior:

1. First, open a CSV/TSV file
2. Then, click on the "Parse next 1 lines as column headers"

Current Results

Expected Behavior

In this case I was actually trying to get both checkboxes to be not checked (so that my project gets created with Column 1, Column 2… as column headers). I can achieve this by keeping the Parse next… checkbox on and setting the number of lines to 0 but that is a bit counter-intuitive.

Versions

• Operating System: Debian
• Browser Version: Firefox
• JRE or JDK Version: 11
• OpenRefine: master (3.6 SNAPSHOT)

[rachittiwari8562]

I have tweaked the ui a little bit . Does it look fine?

[rachittiwari8562]

I think both of the options should be connected as when the user is trying to enter the column names himself , then the parse next checkbox should be turned off .

[wetneb]

I absolutely love it!

[thadguidry]

Maybe the Use character could be moved above the Trim ?

[rachittiwari8562]

Does this fulfil the requirement...?

[rachittiwari8562]

In addiion to this I have tried to add some visual seperation between the 3sections .

Should I move forward with this design or revert back to previous one..

[thadguidry]

@rachittiwari8562 The visual separation is optional and we don't have that in the other import loaders so I would remove those vertical section separators here in the CSV importer for now. Then I think we can merge. There are many many things that visually I would like to see changed and restyled throughout OpenRefine, but first we need a comprehensive plan and that will likely come after or along with OpenRefine 4.0 in phases.

[rachittiwari8562]

Got it...