Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running OpenRefine on Windows without Java points to Oracle website #4511

Closed
wetneb opened this issue Feb 8, 2022 · 2 comments · Fixed by #4563
Closed

Running OpenRefine on Windows without Java points to Oracle website #4511

wetneb opened this issue Feb 8, 2022 · 2 comments · Fixed by #4563
Labels
java version compatibility Making sure OpenRefine runs on as many Java versions as possible packaging How we distribute OpenRefine to end users, on various operating systems Platform: Windows Indicates that the issue or feature is specific to the Windows operating system. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone

Comments

@wetneb
Copy link
Sponsor Member

wetneb commented Feb 8, 2022

When running OpenRefine without Java on Windows, users are redirected to https://java.com/en/download/manual.jsp, which proposes to download Java 8. That is a bad idea, since OpenRefine 3.6 will not be compatible with Java 8 anymore (only Java 11+).

We should consider updating this link (if it is possible) and changing it to a user-friendly alternative.

@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. java version compatibility Making sure OpenRefine runs on as many Java versions as possible Platform: Windows Indicates that the issue or feature is specific to the Windows operating system. labels Feb 8, 2022
@thadguidry
Copy link
Member

thadguidry commented Feb 8, 2022

As well as update our link for setting up JDK in our technical docs:
https://docs.openrefine.org/technical-reference/build-test-run#set-up-jdk

I am absolutely OK to point users to OpenJDK https://openjdk.java.net/
or directly to the latest GA (General-Availability) release of JDK which it links to currently here https://jdk.java.net/17/

JRE is no longer "built" by Oracle for consumers and stopped after Java 8+ and is now subscription only. So users on Windows can 1. build JRE themselves or 2. use the Reference Implementations already built from the OpenJDK source code and stored at jdk.java.net

I think for regular users, they will likely want to use our embedded Java releases.
For those users that do not (or cannot) because of some IT policy, then we can only give suggestions of where they can get a JRE or JDK from and at this point, getting a JRE for Windows users is beyond painful (and looks like it's not even necessary anymore since Java 11) and so we might skip the entire JRE conversation now in 2022, but getting and installing the JDK and setting JAVA_HOME is fairly trivial.

@wetneb wetneb added the packaging How we distribute OpenRefine to end users, on various operating systems label Feb 8, 2022
@thadguidry
Copy link
Member

thadguidry commented Feb 8, 2022

Or better yet... which is what Microsoft is doing...pointing folks to this: https://adoptopenjdk.net/ (and part of Eclipse Foundation soon) which it seems this might be the best starting link to get JRE or JDK for Java 11 (our minimum) for Windows folks

Also if I look deeper, Temurin is what we actually build our packages upon (GitHub Virtual Environments with ubuntu-latest) that we have specified in our CI :

Java

Version Vendor Environment Variable
8.0.312+7 Eclipse Temurin JAVA_HOME_8_X64
11.0.14+9 (default) Eclipse Temurin JAVA_HOME_11_X64
17.0.2+8 Eclipse Temurin JAVA_HOME_17_X64

@wetneb How do you feel about using that above link to update our docs with for openjdk11 as a minimum on adoptium.net?

@wetneb wetneb added this to the 3.6 milestone Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java version compatibility Making sure OpenRefine runs on as many Java versions as possible packaging How we distribute OpenRefine to end users, on various operating systems Platform: Windows Indicates that the issue or feature is specific to the Windows operating system. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants