Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully rename the Wikidata extension into the Wikibase extension #4525

Closed
wetneb opened this issue Feb 12, 2022 · 13 comments · Fixed by #5350
Closed

Fully rename the Wikidata extension into the Wikibase extension #4525

wetneb opened this issue Feb 12, 2022 · 13 comments · Fixed by #5350
Assignees
Labels
Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration
Milestone

Comments

@wetneb
Copy link
Member

wetneb commented Feb 12, 2022

The Wikidata extension has been generalized to work with third-party Wikibase instances.
But there are still a couple of places where Wikidata is mentioned but it should really be Wikibase:

  • The extension menu (in the top right corner of the project screen)
  • The directory extensions/wikidata in the repository should be extensions/wikibase
  • The namespace org.openrefine.wikidata should be org.openrefine.wikibase
  • Probably other places I forgot about

It would be worth doing these changes, ideally when no other open PR touches the Wikidata extension.

@wetneb wetneb added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration labels Feb 12, 2022
@wetneb
Copy link
Member Author

wetneb commented Feb 12, 2022

There are also a lot of references to Wikidata in the translations of the Wikibase extension, they should also be cleaned up.

@khadijm
Copy link
Contributor

khadijm commented Mar 6, 2022

hi, I am a newbie, I am interested to work on this issue in order to get started with the community

@wetneb
Copy link
Member Author

wetneb commented Mar 7, 2022

Thank you for volunteering, please go ahead!

@elroykanye
Copy link
Member

Hello @wetneb , this issue has not been resolved yet and I actually noticed this and have had confusions when reading it 😄
Anyway, I'd like to help with this if that is alright?

@wetneb
Copy link
Member Author

wetneb commented Mar 26, 2022

Let's first check if @khadijm is still working on it.

@elroykanye
Copy link
Member

Alright

@khadijm
Copy link
Contributor

khadijm commented Mar 28, 2022

thanks @wetneb i still working on it, i will a PR soon

@khadijm
Copy link
Contributor

khadijm commented Mar 28, 2022

@wetneb additional detail are needed

there are 2 directory wikibase and wikidata as you can see in this folder.
Screenshot from 2022-03-28 21-00-58

we cannot rename The directory extensions/wikidata to extensions/wikibase because there is already a directory name wikibase.

@khadijm
Copy link
Contributor

khadijm commented Mar 28, 2022

are we to delete the current wikibase directory before renaming wikidata to wikibase ? @wetneb

@wetneb
Copy link
Member Author

wetneb commented Mar 29, 2022

I am not sure what happened on your side, but in the repository, there is currently only a wikidata directory, not a wikibase one:
https://github.com/OpenRefine/OpenRefine/tree/master/extensions
Or am I looking at the wrong location?

@khadijm
Copy link
Contributor

khadijm commented Mar 29, 2022

thanks @wetneb i see the problem, i am pulling from my fork https://github.com/khadijm/OpenRefine instead of pulling from https://github.com/OpenRefine/OpenRefine

@antoine2711
Copy link
Member

@khadijm: are you still working on this issue?

Regards, Antoine

@trnstlntk trnstlntk moved this to To be triaged in Structured Data on Commons Jul 3, 2022
@trnstlntk trnstlntk moved this from To be triaged to 🛣 Out of WMF grant scope but on our radar in Structured Data on Commons Jul 3, 2022
@trnstlntk trnstlntk moved this from 🛣 Out of WMF grant scope but on our radar to 📡 On the radar / Dependencies in Structured Data on Commons Sep 27, 2022
@wetneb wetneb added this to the 3.7 milestone Oct 5, 2022
@wetneb wetneb self-assigned this Oct 18, 2022
wetneb added a commit to wetneb/OpenRefine that referenced this issue Oct 18, 2022
Repository owner moved this from 📡 On the radar to ✅ Done in Wikibase support 2022: file upload, custom data types Oct 19, 2022
Repository owner moved this from 📡 On the radar / Dependencies to SDC (WMF) grant 2021-22 - done in Structured Data on Commons Oct 19, 2022
wetneb added a commit that referenced this issue Oct 19, 2022
* Rename Wikidata to Wikibase extension. Closes #4525.

* Update Cypress tests

* Further renames in Cypress tests
@thadguidry
Copy link
Member

@wetneb thanks for finishing this up!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration
Projects
Status: SDC (WMF) grant 2021-22 - done
Development

Successfully merging a pull request may close this issue.

5 participants