Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chevrons not rendered correctly in "undo" notification #4540

Closed
hughlilly opened this issue Feb 17, 2022 · 3 comments · Fixed by #4710
Closed

Chevrons not rendered correctly in "undo" notification #4540

hughlilly opened this issue Feb 17, 2022 · 3 comments · Fixed by #4710
Assignees
Labels
encoding Selection of encoding at import time, or encoding issues in data cleaning Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone

Comments

@hughlilly
Copy link
Contributor

hughlilly commented Feb 17, 2022

Chevrons («») are not rendered correctly in the "undo" notification.

To Reproduce

  1. Run the "Replace smart quotes with ascii" common transform on a text column
  2. Observe that the "undo" notification contains replacement characters instead of chevrons

Current Results

Chevrons appear in the history list OK, but not in the "undo" notification, which times out and disappears.

Expected Behavior

The chevrons should be accurately rendered in this modal.

Screenshots

image

image

Versions

  • Operating System: macOS 12.1 (21C52)
  • Browser Version: Safari 15.2 (17612.3.6.1.6)
  • User-agent string: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.2 Safari/605.1.15"
  • JRE or JDK Version: Sorry, I can't get this info immediately; if there is a separate fix for this issue or if my system is not set up correctly please let me know.
❯ which java
/usr/bin/java
~ 
❯ java --version
The operation couldn’t be completed. Unable to locate a Java Runtime.
Please visit http://www.java.com for information on installing Java.

Datasets

I don't believe this is caused by my data but am happy to attach it here if doing so would help fix the bug.

Thanks
Hugh

@hughlilly hughlilly added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Feb 17, 2022
@wetneb wetneb added the encoding Selection of encoding at import time, or encoding issues in data cleaning label Feb 17, 2022
@trnstlntk
Copy link
Contributor

The yellow notification thingy at the top shows encoding errors quite frequently. I also see it a lot while doing manual reconciliation.

Screenshot:
Screen Shot 2022-03-10 at 20 25 36

To reproduce:

  • take a list of e.g. person names with many diacritics
  • reconcile in such a way that you'll have quite a few entries to match by hand
  • do that
  • see the encoding issues

Here's a small dataset with many person names with diacritics for testing: documenta-13-artists.csv

@thadguidry
Copy link
Member

Hi @trnstlntk is it only the notification banner, or do you see that unicode replacement char U+FFFD � in other display dialogs or areas of OpenRefine?

@trnstlntk
Copy link
Contributor

I remember only seeing it in the yellow notification banner, but I'll keep my eyes peeled for other occurrences.

@elebitzero elebitzero self-assigned this Apr 6, 2022
@wetneb wetneb added this to the 3.6 milestone Apr 25, 2022
@tfmorris tfmorris removed the Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
encoding Selection of encoding at import time, or encoding issues in data cleaning Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants