Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing XML doesn't populate Import Options metadata #4566

Closed
deckerrj opened this issue Feb 25, 2022 · 0 comments · Fixed by #4567
Closed

Importing XML doesn't populate Import Options metadata #4566

deckerrj opened this issue Feb 25, 2022 · 0 comments · Fixed by #4567
Labels
import About importers in general - add a label for the data format if available Type: Bug Issues related to software defects or unexpected behavior, which require resolution. XML About XML import
Milestone
3.6

Comments

@deckerrj
Copy link
Contributor

When importing an XML document in OpenRefine 3.5.2, the Import Options metadata does not get populated.

To Reproduce

Create a new project the attached XML sample, use item as the first record.

Current Results

Import option metadata is empty

Expected Behavior

Import option metadata should contain filename, record path, and other data

Versions

  • Operating System: MacOS Big Sur 11.6.4
  • Browser Version: Chrom 98.0.4758.102
  • JRE or JDK Version: java version "13.0.2" 2020-01-14
  • OpenRefine: OpenRefine 3.5.2

Datasets

sample.zip
GitHub doesn't support directly uploading the XML file, so it's been zipped.

Additional context

This may affect other importers than just XML.
@deckerrj deckerrj added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Feb 25, 2022
@wetneb wetneb added import About importers in general - add a label for the data format if available XML About XML import labels Feb 25, 2022
deckerrj pushed a commit to deckerrj/OpenRefine that referenced this issue Feb 25, 2022
Fixes OpenRefine#4566
33957c8 
Duplicates the base ImportingParserBase metadata append
into the TreeImportingParserBase, which completely
overrides the original method.
deckerrj pushed a commit to deckerrj/OpenRefine that referenced this issue Feb 25, 2022
Fix missing import options metadata for XML
7ef0537 
Fixes OpenRefine#4566

Duplicates the base ImportingParserBase metadata append
into the TreeImportingParserBase, which completely
overrides the original method.
@deckerrj deckerrj mentioned this issue Feb 25, 2022
Merged
@wetneb wetneb removed the Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators label Feb 26, 2022
@wetneb wetneb added this to the 3.6 milestone Feb 26, 2022
wetneb pushed a commit that referenced this issue Feb 26, 2022
@deckerrj
Fix missing import options metadata for XML (#4567)
ab96af5 
Fixes #4566

Duplicates the base ImportingParserBase metadata append
into the TreeImportingParserBase, which completely
overrides the original method.

Co-authored-by: Robin Decker <deckerrj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
import About importers in general - add a label for the data format if available Type: Bug Issues related to software defects or unexpected behavior, which require resolution. XML About XML import
Projects
None yet
Milestone
3.6
Development

Successfully merging a pull request may close this issue.

Fix missing import options metadata for XML deckerrj/OpenRefine
2 participants
@wetneb @deckerrj