Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"manifest.version should match pattern "^1\.[0-9]+$"" error for 'Commons manifest version 2.0 #4847

Closed
VDK opened this issue May 12, 2022 · 1 comment · Fixed by #4941
Closed
Assignees
Labels
error handling Improving the ways errors are reported to users Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration
Milestone

Comments

@VDK
Copy link
Contributor

VDK commented May 12, 2022

The regex should be changed to ^[1-9]{1,3}.[0-9]+$, the current version of the Wikimedia Commons manifest is 2.0, and thus creates this error.
Secondly: there should be a space and not a period in its error message.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the Wikibase schema
  2. The "Wikidata" dropdown in the top-right corner, pick "Select Wikibase instance"
  3. "Add Wikibase" option
  4. Wikimedia Commons wikibase manifest, either copy it or put in this URL
  5. "manifest.version should match pattern "^1.[0-9]+$""

Current Results

Unable to add Wikimedia Commons as a Wikibase Instance

Expected Behavior

Not this error.

Screenshots

Versions

  • Operating System: Windows 11
  • Browser Version: Chrome 101.0.4951.54
  • JRE or JDK Version: java version "1.8.0_331"
    Java(TM) SE Runtime Environment (build 1.8.0_331-b09)
    Java HotSpot(TM) 64-Bit Server VM (build 25.331-b09, mixed mode)
  • OpenRefine: Version 3.5.2 [e3efd4e]

Additional context

As a side note: "manifests for some public Wikibases can be found here" should be changed to "See the overview of public Wikibases manifests". Read more about why you shouldn't label links with "click here"

@VDK VDK added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels May 12, 2022
@wetneb
Copy link
Member

wetneb commented Jun 3, 2022

So, this error was encountered when trying to use a manifest with a version of OpenRefine that does not support such a new version of the manifest syntax.

It is good that we are preventing the user to add the manifest in this case, but we could have a better error message, indicating that the user needs a more recent version of OpenRefine to work with this manifest.

@wetneb wetneb added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. error handling Improving the ways errors are reported to users wikibase Related to wikidata/wikibase integration and removed Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Jun 3, 2022
@elebitzero elebitzero self-assigned this Jun 8, 2022
@wetneb wetneb added this to the 3.7 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error handling Improving the ways errors are reported to users Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants