Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODS exporter adds an additonal empty sheet to the project #4864

Closed
wetneb opened this issue May 18, 2022 · 3 comments · Fixed by #4900
Closed

ODS exporter adds an additonal empty sheet to the project #4864

wetneb opened this issue May 18, 2022 · 3 comments · Fixed by #4900
Assignees
Labels
export Exporting a project to some format. Use the format-specific sub-label if available Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. ODS Import/export from/to LibreOffice spreadsheets Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone

Comments

@wetneb
Copy link
Member

wetneb commented May 18, 2022

The ODF exporter creates files with two sheets: the first is empty, and the second contains the project data. We should remove the first one.

To Reproduce

Steps to reproduce the behavior:

  1. First, export any project to ODF
  2. Then, open it (for instance with LibreOffice)

Current Results

The exported file contains two sheets, the first one being empty.

Expected Behavior

The exported file should contain a single sheet with the project data.

Versions

  • Operating System: Debian
  • JRE or JDK Version: 11
  • OpenRefine: 3.6-SNAPSHOT

Datasets

Example exported file: Clipboard.ods

Additional context

Similar to #4738

@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. export Exporting a project to some format. Use the format-specific sub-label if available ODS Import/export from/to LibreOffice spreadsheets labels May 18, 2022
@vdimopoulos
Copy link

Can you assign me to this one? Thank you in advance!

@xiao2k
Copy link
Contributor

xiao2k commented May 28, 2022

I think we can use getTableByName("Sheet1") and defTable.remove(); to solve this issue.

I did a little change to have a try.

@wetneb
Copy link
Member Author

wetneb commented May 28, 2022

@xiao2k since @vdimopoulos was assigned to this issue, it is nice if you can check with them first if they are still working on this issue before working on it yourself. No worries for this time though, I think 10 days is indeed enough to tackle something like this :)

@wetneb wetneb added this to the 3.7 milestone Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
export Exporting a project to some format. Use the format-specific sub-label if available Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. ODS Import/export from/to LibreOffice spreadsheets Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants