Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scatterplot facet should show error on non-numeric column #4890

Closed
elebitzero opened this issue May 25, 2022 · 0 comments · Fixed by #4893
Closed

Scatterplot facet should show error on non-numeric column #4890

elebitzero opened this issue May 25, 2022 · 0 comments · Fixed by #4893
Assignees
@elebitzero
Labels
error handling Improving the ways errors are reported to users facets Behaviour or rendering of facets in a project Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
3.7

Comments

@elebitzero
Copy link
Member

Column->Facet->Scatterplot facet requires the selected column to be numeric and at least one other numeric column.

To Reproduce

  1. Create Project. Choose sample file foods.csv
  2. Next then Create Project
  3. Calcium Column -> Facet -> Scatterplot Facet

Current Results

Scatterplot shows a blank dialog when invoked on a non-numeric column.

Expected Behavior

An error message should be displayed.

Screenshots

image
@elebitzero elebitzero added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels May 25, 2022
@elebitzero elebitzero self-assigned this May 25, 2022
@elebitzero elebitzero mentioned this issue May 25, 2022
Closed
@thadguidry thadguidry added error handling Improving the ways errors are reported to users and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels May 25, 2022
@wetneb wetneb added the facets Behaviour or rendering of facets in a project label May 26, 2022
@elebitzero elebitzero mentioned this issue May 26, 2022
Merged
@wetneb wetneb modified the milestones: 3.6, 3.7 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elebitzero elebitzero

Labels
error handling Improving the ways errors are reported to users facets Behaviour or rendering of facets in a project Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.7
Development

Successfully merging a pull request may close this issue.

Added error messages for scatterplot facet elebitzero/OpenRefine
3 participants
@wetneb @thadguidry @elebitzero