Skip to content

Check that created Wikibase items have distinct (name,description) pairs #4980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CollectieDIVA opened this issue Jun 22, 2022 · 6 comments · Fixed by #5327
Closed

Check that created Wikibase items have distinct (name,description) pairs #4980

CollectieDIVA opened this issue Jun 22, 2022 · 6 comments · Fixed by #5327
Labels
Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration

Comments

@CollectieDIVA
Copy link

Hi all,

I am creating new Wikidata entries for a museum via OR (version 3.5) using the Wikidata extension. However, I have had several instances where the edits do not perform from a certain point onwards. Strange but perhaps important detail: OR shows the edits as 78% complete, while in Wikidata I can see in my contributions that only about 30 of the 293 items of Part 4 of the public domain upload for the DIVA museum have been uploaded. Many titles are the same (Lepel, Vork, Modelprent met verschillende voorwerpen, ...), but it seems to me that this cannot be the problem, right? They are in fact different objects, as you can see in the object number column, and thus I created new items for each cell.

To Reproduce

Steps to reproduce the behavior:

  1. Reconciliation of column Title (= item)
  2. If the item doesn't exist > Actions > Create new item for each cell
  3. Edit Wikibase schema
  4. Upload edits to Wikibase

Screenshots

Screenshot 2022-06-22 at 12-13-21 78% complete - Publiek domein upload DIVA - OpenRefine
afbeelding

Versions

  • Operating System: Windows 10,
  • Browser Version: Chrome 19, Firefox 61
  • OpenRefine: OpenRefine 3.5
@CollectieDIVA CollectieDIVA added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Jun 22, 2022
@trnstlntk
Copy link
Contributor

@CollectieDIVA On Wikidata, the combination of label and description needs to be unique. I think that's why your upload stalls: you are trying to create many items with the exact same label and description.

You can address this by making sure each label is unique; I would advise you to add (DIVA Pxxxx/x/xx)at the end of each label for that, e.g. for your item on line 77 I would make sure it has the Title Modelprent met verschillende ontwerpen (DIVA P2013/1/36).

To make sure that it will work correctly, I would first remove the reconciliation judgments from the items that are indicated as 'create new items', then change their Title in OpenRefine according to my recommendations above, then reconcile them with Wikidata again and then again mark as new.

In your current situation, in the Issues tab, I think you should also see a message that warns you about trying to create items with identical labels. Are you seeing this indeed?

@wetneb
Copy link
Member

wetneb commented Jun 23, 2022

I do not think we have such a check implemented yet - I think it would be a good idea to add one indeed!

@trnstlntk
Copy link
Contributor

I do not think we have such a check implemented yet - I think it would be a good idea to add one indeed!

It would be very useful. Even I, as a very experienced OpenRefine user, creating new items in Wikidata regularly, still come across this issue all the time!

@trnstlntk
Copy link
Contributor

trnstlntk commented Jun 23, 2022

Ideally, one should be able to create separate Wikidata items (and Wikibase items) with identical labels, as long as the description is then unique.

@CollectieDIVA
Copy link
Author

@CollectieDIVA On Wikidata, the combination of label and description needs to be unique. I think that's why your upload stalls: you are trying to create many items with the exact same label and description.

You can address this by making sure each label is unique; I would advise you to add (DIVA Pxxxx/x/xx)at the end of each label for that, e.g. for your item on line 77 I would make sure it has the Title Modelprent met verschillende ontwerpen (DIVA P2013/1/36).

To make sure that it will work correctly, I would first remove the reconciliation judgments from the items that are indicated as 'create new items', then change their Title in OpenRefine according to my recommendations above, then reconcile them with Wikidata again and then again mark as new.

In your current situation, in the Issues tab, I think you should also see a message that warns you about trying to create items with identical labels. Are you seeing this indeed?

Hi, thanks for your reply! As confirmed above, I did not get that warning message. I'll try again using your advice, but ideally, as you've mentioned, we would be able to upload identical labels, as long as the description or inventory number would be unique. But for now, I'll give your suggestion a try and give you a quick heads up if it helps.

@wetneb wetneb changed the title Wikibase edits bug Check that created Wikibase items have distinct (name,description) pairs Oct 7, 2022
@wetneb wetneb added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration and removed Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Oct 7, 2022
@wetneb
Copy link
Member

wetneb commented Oct 7, 2022

So let us say that the solution to this issue is to implement a QA check in the Wikibase extension, which detects when the user wants to create items which share a common (name,description) pair in a given language. The severity of the warning raised in that case should be "critical", because that prevents the batch from being uploaded.

wetneb added a commit to wetneb/OpenRefine that referenced this issue Oct 8, 2022
wetneb added a commit that referenced this issue Oct 13, 2022
…s. (#5327)

* Add QA check for identical label and description in new Wikibase items.

Closes #4980.

* Add missing imports due to merge
@tfmorris tfmorris modified the milestone: 3.8 Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants