Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Confirm dialog for Starred expression Remove links #501

Closed
tfmorris opened this issue Oct 15, 2012 · 7 comments · Fixed by #3436
Closed

Add a Confirm dialog for Starred expression Remove links #501

tfmorris opened this issue Oct 15, 2012 · 7 comments · Fixed by #3436
Assignees
@cbedard
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. help wanted An issue that we would love anyone to help us with imported from old code repo Issue imported from Google Code in 2010 Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Priority: Medium Represents important issues that need to be addressed but are not urgent Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Milestone
3.5

Comments

@tfmorris
Copy link
Member

tfmorris commented Oct 15, 2012 •
edited by thadguidry
Loading

Original author: thadguidry (December 01, 2011 15:32:49)

Using Expression Editor and the Starred expression tab.

It would be nice to have an extra "Confirm ?" popup dialog with REMOVE CANCEL buttons when a user clicks Remove link on a Starred expression.

With the slip of a mouse button, I just lost a very long and nice expression that took me 15 mins to pull together with some research, and probably should have just stored that in a Notepad document and uploaded to Google Docs for safekeeping. :)

Original issue: http://code.google.com/p/google-refine/issues/detail?id=501
@thadguidry thadguidry added Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. help wanted An issue that we would love anyone to help us with labels Apr 17, 2018
@wetneb wetneb added the Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. label Dec 20, 2019
@ghost
Copy link

ghost commented Mar 2, 2020

Hey, I would like to solve this problem. Can I work on this issue?

@wetneb
Copy link
Member

wetneb commented Mar 2, 2020

You can! Thanks for volunteering :)

@wetneb wetneb assigned ghost Mar 2, 2020
@TejaswiKarasani
Copy link

@wetneb I would like to take up the issue if other is not working on it

@ghost
Copy link

ghost commented Mar 9, 2020

@wetneb I would like to take up the issue if other is not working on it

I was working on it.

@wetneb
Copy link
Member

wetneb commented Mar 9, 2020

@kushthedude please do not assign the same issue to multiple people unless they are explicitly collaborating together - the point of assigning people to issues is to avoid duplication of efforts. Thank you!

@cbedard
Copy link
Contributor

cbedard commented Dec 22, 2020 •
edited
Loading

Hello, it doesn't look like anything was submitted for this, can I work on it?

I have changes on my fork already, just want to ask before submitting a PR.
ConfirmDialogSS

@wetneb
Copy link
Member

wetneb commented Dec 23, 2020

@CameronBedard sure, thank you!

@cbedard cbedard mentioned this issue Dec 23, 2020
Merged
wetneb added a commit that referenced this issue Jan 2, 2021
@cbedard @wetneb
Added confirm dialog for starred expression remove links #501 (#3436)
c6b6616 
* Updated 'remove' link for starred expressions to include a confirm dialog

* bring remove expression dialog dismissal inline with other dialog dismissal

* Changed 'unstar expression?' in translation-en.json to allow better translation.

* Update main/webapp/modules/core/langs/translation-en.json

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
@wetneb wetneb added this to the 3.5 milestone Jan 2, 2021
@wetneb wetneb mentioned this issue Apr 24, 2021
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbedard cbedard

Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. help wanted An issue that we would love anyone to help us with imported from old code repo Issue imported from Google Code in 2010 Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Priority: Medium Represents important issues that need to be addressed but are not urgent Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

Added confirm dialog for starred expression remove links #501
5 participants
@tfmorris @wetneb @thadguidry @cbedard @TejaswiKarasani