Skip to content

In the "Add column based on this column" dialog, validating a form by pressing Enter should run the operation #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wetneb opened this issue Aug 3, 2022 · 0 comments · Fixed by #5149
Assignees
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Milestone

Comments

@wetneb
Copy link
Member

wetneb commented Aug 3, 2022

When adding a column based on a column, I often first type the expression I want, and then set a column name in the field at the top, and then press Enter, expecting it to have the same effect as clicking the "OK" button. It currently does not do anything.

Proposed solution

This field should be part of a form, and when that form is submitted, that should be equivalent to pressing the OK button.
This should not require setting up any event listener on keyboard events, but instead integrate the existing input fields in a form, and binding the submission event on that form to the execution of the operation (and closing the dialog).

Alternatives considered

None.

Screenshot

image

@wetneb wetneb added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. labels Aug 3, 2022
@elebitzero elebitzero self-assigned this Aug 4, 2022
wetneb pushed a commit that referenced this issue Aug 9, 2022
…dd column based on this column' dialog (#5149)

* Added the ability to submit the form data by pressing enter on the add column based on this column dialog.

* Cleanup, added type="submit" to the OK button.

Fixes #5143.
@wetneb wetneb added this to the 3.7 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
2 participants