Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion of properties and items in the Wikibase schema builder sometimes totally refuses to load any suggestions (or only wrong ones) #5190

Closed
trnstlntk opened this issue Aug 16, 2022 · 3 comments · Fixed by #5328
Assignees
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution. wikibase Related to wikidata/wikibase integration
Milestone

Comments

@trnstlntk
Copy link
Contributor

Sometimes, item and property suggestion in the Wikibase extension's schema builder simply refuses to work (refusing to provide any suggestions at all, or only wrong suggestions), making schema building quite painful.

This issue is difficult to reproduce - I have seen the behavior quite often but haven't discovered a pattern in it. I was recently creating a screen recording while it happened badly and you can see it happening in this video.

Reproducing my process (but I have the idea it doesn't only happen under these circumstances):

  • I added what I thought was a wrong statement in the schema builder, deleted the statement, and then tried to recreate it. I wanted the same property but another value. Property (Source of file) simply refuses to load.
  • Then you see me fiddling a bit, working on other statements, trying if moving out of the schema builder and back fixes it (it does not)
  • Finally I decide to exit my project and go back to OpenRefine's start screen and re-open the project. Then I can add the statement just fine and the suggester does its job.

Unfortunately I didn't have the Terminal running, so I don't have a log of what happened.

This issue has been reported on Wikimedia's OpenRefine Telegram group as well.

Expected Behavior

Properties and items display correctly and promptly.

Versions

  • Operating System: MacOS 12.5
  • Browser Version: Something probably right before Chrome 104.0.5112.79 (Official Build) (x86_64)
  • JRE or JDK Version: n/a?
  • OpenRefine: 3.7 snapshot release of 13 August 2022
@trnstlntk trnstlntk added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators wikibase Related to wikidata/wikibase integration labels Aug 16, 2022
@wetneb
Copy link
Member

wetneb commented Aug 16, 2022

Very mysterious! One possible explanation: the suggest service fails at some point, and that failure is cached by the suggest widget, meaning that it will not retry this request if the exact same text is in the input field. If that is the case then we just need to make sure we only cache successful fetches.
I also made some cleanups when looking into this issue earlier, intuitively they should not hurt, but I am not really convinced they have anything to do with this issue.

@wetneb
Copy link
Member

wetneb commented Aug 18, 2022

I have also experienced this and it seems related to caching. Refreshing the page flushes that cache and then the auto-completion should work again after that.
I would like to understand the problem fully but disabling this caching should be a workaround.

@wetneb wetneb added Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Aug 18, 2022
@j-sal
Copy link
Contributor

j-sal commented Oct 10, 2022

I have also experienced this in the Commons Extension category suggestion service.

After typing the first few letters of a category, i.e "dog", and selecting a category from the suggestions, i.e "dog breeds"
image

If that category is removed, and then the same initial letters are re-typed, the suggestions no longer load any options
image

@wetneb wetneb added this to the 3.7 milestone Oct 10, 2022
@wetneb wetneb self-assigned this Oct 10, 2022
wetneb added a commit to wetneb/OpenRefine that referenced this issue Oct 10, 2022
wetneb added a commit that referenced this issue Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution. wikibase Related to wikidata/wikibase integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants