Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dysfunctional reconciliation dialog window in OpenRefine 3.7 snapshots (since around Sep 20, 2022) #5285

Closed
trnstlntk opened this issue Sep 24, 2022 · 1 comment · Fixed by #5286
Assignees
Labels
reconciliation Related to the reconciliation operations and other features Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone

Comments

@trnstlntk
Copy link
Contributor

I tried reconciling against Wikidata in a large-ish dataset using our 3.7 snapshot release, and the reconciliation dialog appears wonky at the bottom. The Start reconciling and Cancel buttons are dysfunctional (nothing happens when clicking them).

image

To Reproduce

The bad things happened with this dataset: homosaurus-v3-jsonld.openrefine.tar.gz
I tried reconciling the http://www.w3.org/2004/02/skos/core#prefLabel column
In Version 3.7-SNAPSHOT [549f83b] and the September 21 snapshot release.

I loaded this same dataset in OpenRefine 3.6.1 on Wikimedia PAWS, where the window does behave as expected, so it seems like the issue was recently introduced.

Versions

  • Operating System: MacOS 12.6
  • Browser Version: Chrome Version 105.0.5195.125 (Official Build) (arm64)
  • JRE or JDK Version: n/a?
  • OpenRefine: Version 3.7-SNAPSHOT [549f83b] and the September 21 snapshot release
@trnstlntk trnstlntk added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators reconciliation Related to the reconciliation operations and other features UX labels Sep 24, 2022
@wetneb wetneb self-assigned this Sep 25, 2022
wetneb added a commit to wetneb/OpenRefine that referenced this issue Sep 25, 2022
We plan to redesign this dialog completely - there are a lot of issues with it.
This is just a fairly minimal fix to avoid its contents overflowing and hiding
the "Reconcile" and "Cancel" buttons.

Closes OpenRefine#5285.
@elebitzero
Copy link
Member

@trnstlntk , this is also reproducible in 3.5.2 and 3.6.1. It happens when the list of types doesn't have any long entries which makes the width of the column is narrower, and the controls at the bottom are in that same column so they wrap. You can see what happens in screenshots below (from 3.5.2):
image
image

@wetneb wetneb removed the Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators label Sep 26, 2022
@wetneb wetneb closed this as completed in 28307f2 Sep 26, 2022
@wetneb wetneb added this to the 3.6 milestone Sep 26, 2022
wetneb added a commit that referenced this issue Oct 3, 2022
* Fix recon dialog overflow issue.

We plan to redesign this dialog completely - there are a lot of issues with it.
This is just a fairly minimal fix to avoid its contents overflowing and hiding
the "Reconcile" and "Cancel" buttons.

Closes #5285.

* Add min-height to fix service selection issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reconciliation Related to the reconciliation operations and other features Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants