Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proportions of Wikibase logos are not respected in the Wikibase management dialog #5306

Closed
wetneb opened this issue Oct 1, 2022 · 0 comments · Fixed by #5307
Closed

Proportions of Wikibase logos are not respected in the Wikibase management dialog #5306

wetneb opened this issue Oct 1, 2022 · 0 comments · Fixed by #5307
Assignees
@wetneb
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution. wikibase Related to wikidata/wikibase integration

Comments

@wetneb
Copy link
Member

wetneb commented Oct 1, 2022

In this dialog, the logos that are not natively square are stretched, not preserving their aspect ratio:
image

Not providing more details because I am intending to tackle this issue directly.
@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. wikibase Related to wikidata/wikibase integration labels Oct 1, 2022
@wetneb wetneb self-assigned this Oct 1, 2022
wetneb added a commit to wetneb/OpenRefine that referenced this issue Oct 1, 2022
@wetneb
Preserve aspect ratio of Wikibase logos. Closes OpenRefine#5306
3b6c3b8
@wetneb wetneb mentioned this issue Oct 1, 2022
Merged
wetneb added a commit that referenced this issue Oct 4, 2022
@wetneb
Preserve aspect ratio of Wikibase logos. Closes #5306 (#5307)
d5c599a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wetneb wetneb

Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution. wikibase Related to wikidata/wikibase integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve aspect ratio of Wikibase logos wetneb/OpenRefine
1 participant
@wetneb