-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster and edit changes space character in values to nbsp #5581
Comments
Argh, I should have thought about this! I indeed introduced those non-breaking spaces in the UI to make sure that options which differed in spaces were rendered differently in the dialog, but I did not think the values were read from the DOM when merging a cluster. Sorry about this! I'll work on a fix asap. |
Thanks @wetneb And @thadguidry, I'm sorry I wasn't clear in my op, but it occurs when values already have spaces in them, so I think if you check 'small size' you'll see what I'm talking about. |
Note that I could only reproduce this bug with Chromium, not with Firefox. I think it is known that they do not handle non-breaking spaces in the same way (or at least, until recently). |
If I may add to this issue... this non-breaking space added during clustering appears as It also prevents text filtering in OpenRefine when using a normal space. For example, after clustering, the string I'm using version 3.6.2 on Windows, Firefox. |
This issue should be fixed in 3.7-beta5. |
When using cluster and edit, when you select an existing value by clicking on the hyperlinked option, it replaces any spaces in the original values with non-breaking spaces. See here.
To Reproduce
Steps to reproduce the behavior:
Current Results
Space replaced with non-breaking space which can cause inconsistencies with rest of data
Expected Behavior
Should not alter original data in this way
Screenshots
Versions
Datasets
Additional context
The text was updated successfully, but these errors were encountered: