Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
OpenRefine Database Import Extension #1394
wetneb left a comment
From what I can see, it looks very nice, clean and usable. But, there are a few issues that should be addressed before this is merged.
Many unit tests are empty (already pointed out above). It is totally doable to test these features: Travis can run various databases easily, so we should take advantage of that.
Also, the values returned by a SQL queries are typed (string, int, timestamp, and so on): it would be cleaner if these were mapped to the corresponding data types in OpenRefine, rather than storing everything as text. (Maybe this could be enabled / disabled via a checkbox, in the same way that data type auto-detection works for CSV import).
There are also some minor UI issues - I will provide screenshots later on.
Antonin, I am almost done with the issues you raised. I will push the changes before weekend.…
On Wed, Jan 10, 2018 at 4:04 AM, Antonin Delpeuch ***@***.***> wrote: @tcbuzor <https://github.com/tcbuzor> any news on this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1394 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Af2f5QlZIbWuOMrcvRx5IH30NmwnPmuhks5tJIs6gaJpZM4RLlJc> .
Jan 13, 2018