Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to view more than 50 rows #3249

Merged
merged 3 commits into from
Oct 22, 2021

Conversation

Abbe98
Copy link
Member

@Abbe98 Abbe98 commented Oct 5, 2020

Adding the options 100, 500, 1000.

Screenshot from 2020-10-05 16-25-39

Motivation

I have in my own OpenRefine had these options for a while and I have found that it saves scrolling and context switching time when one needs to manually go through large amounts of data, by making sure one does not need to scroll up to access the pagination navigation.

Notes

I have tested the performance of this on two computers and I don't think even the 1000 option will be problematic on most modern computers.

The only past issue on the subject I'm aware of is #303.

Adding the options 100, 500, 1000
@thadguidry thadguidry added the grid pagination / scrolling About scrolling through the rows via pagination or potentially seamless scrolling label Oct 5, 2020
@tfmorris
Copy link
Member

tfmorris commented Oct 5, 2020

Why isn't the solution from #2624 adequate?

@thadguidry
Copy link
Member

Hi @Abbe98 You can take a look at the listing of preferences that can be set on our wiki page here: https://github.com/OpenRefine/OpenRefine/wiki/Preferences

@Abbe98
Copy link
Member Author

Abbe98 commented Oct 5, 2020 via email

@wetneb
Copy link
Sponsor Member

wetneb commented Oct 5, 2020

Just noting that I would hope that we get the infinite scrolling PR merged before the next release (#2746), in which case there will not be any page size selection any longer, so this would only benefit people who run OpenRefine from the master branch (or snapshot releases) in the meantime.

@Abbe98
Copy link
Member Author

Abbe98 commented Oct 9, 2021

A year later I still think this is a good idea, it provides better and much wanted defaults. The settings are still very inaccessible for most and the proposed defaults can be managed by most computers.

@wetneb
Copy link
Sponsor Member

wetneb commented Oct 9, 2021

Hi @Abbe98 (by the way - great live editing screencasts! ;) )
Yes, obviously the infinite scrolling PR did not make it and is unlikely to make it soon.
I would indeed propose to merge this as such.

@wetneb wetneb merged commit 919892b into OpenRefine:master Oct 22, 2021
wetneb added a commit that referenced this pull request Oct 22, 2021
Adding the options 100, 500, 1000

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid pagination / scrolling About scrolling through the rows via pagination or potentially seamless scrolling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants