Skip to content

Add and Remove All buttons for multiple column selection #4557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 23, 2022
Merged

Add and Remove All buttons for multiple column selection #4557

merged 8 commits into from
Feb 23, 2022

Conversation

elebitzero
Copy link
Member

Fixes #4282

Changes proposed in this pull request:

  • Implemented Remove and Add All buttons for moving multiple columns in the All > Edit Columns menu
    all_edit_columns_menu

@github-actions github-actions bot added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. labels Feb 22, 2022
wetneb
wetneb reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks great to me :)

wetneb
wetneb approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging soon unless anyone wants to suggest improvements.

@wetneb wetneb merged commit d8c955c into OpenRefine:master Feb 23, 2022
@elebitzero elebitzero deleted the issue-4282-multiple-column-selection branch March 19, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetneb wetneb wetneb approved these changes

Assignees
No one assigned
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multiple column selection in "Re-order / Remove Columns" modal
2 participants
@elebitzero @wetneb