Upgrading jQuery to 3.6.0

[elebitzero]

Changes proposed in this pull request:

• Upgrade jQuery and jQuery Migrate.

The jQuery migration from 1.12.4 to the latest (3.6.0) version required many fixes due to deprecated and removed methods, and also some behavior changes.

Luckily, all the work was able to be done incrementally since all of the fixes were compatible with the old version (1.12.4).

All of the Cypress tests are passing, and I have done some additional manual testing.

Summary of Changes:

• Replaced usages of jQuery functions removed in 3.6.0 or earlier. (Ref: https://api.jquery.com/category/removed/).
• Replaced usages of jQuery functions deprecated in 3.6.0 or earlier. (Ref: https://api.jquery.com/category/deprecated/).
• Fix broken code due to jQuery no longer auto-inserting tbody tags.
• Correct <textarea/> to <textarea></textarea> becuase latest jQuery did not like self-closing <textarea/>.
• Fix deprecations in external dependencies jquery.imgareaselect.js and suggest-4_3a.js.
• Due to a change in behavior in jQuery $.post(), calls to /command/core/toggle-starred-expression would fail if a "json" is expected, but an empty response is returned. By omitting the expected content type (""), then the content-type is set by the server response. (Ref: AJAX response with empty body runs error function instead of success function. jquery/jquery#3973).
• Updated select2 package which fixed jQuery deprecations.
• Resolves security issues with jquery 1.12.4. (Ref: https://snyk.io/vuln/npm:jquery?lh=1.12.4):
  

Pending:

• The tablesorter dependency has an open PR to remove calls to deprecated functions. (Ref: Fix jquery deprecations Mottie/tablesorter#1786). The current tablesorter does work with jQuery 3.6.0, so it's still okay to go ahead.
• May want to remove jquery-migrate. They don't recommend you have it enabled in production. We should just add it in dev builds when we are doing migrations from one jQuery version to the next.

Associated PRs:

• Fixed jQuery deprecations and a regression in imgareaselect and scatterplot facet #4886
• Fixed jQuery deprecations in edit column, edit cell, transform, and edit all columns #4882
• Fixed jQuery $.trim deprecations #4874
• Updated Select2 dependency to fix jQuery deprecations for the migration #4872
• Fixed jQuery deprecations found in column -> reconcile #4862
• jQuery 3.x Migration - Fixed Test the history, star Test #4861
• Fixed flaky drag-n-drop tests for jQuery migration #4853
• Fixed jQuery deprecations under the Wikidata menu #4852
• Fixed jQuery deprecations in manage Wikibase account dialogs #4851
• Fixed jQuery deprecations in the UIs of the file parsers under create project #4840
• Fixed jQuery deprecations from Cypress tests and external dependencies #4837
• Migrate jQuery deprecated functions #4827
• Updated textarea closing tags for jQuery 3.6.0 support #4822
• Updated tests for jQuery migration #4817
• Replaced usage of removed load method for jQuery #4811

[wetneb]

Very nice, thank you for the amazing work!
In terms of schedule, I wonder if we want to have this in 3.6. This is going to be a breaking change for some extensions, I suspect. I guess we could decide to put this in 4.0 only and keep the 3.x series as compatible as possible. But then jQuery 1.12.4 does have some vulnerabilities so I guess there is also a case for migrating it in 3.x directly.

[elebitzero]

Is OpenRefine 3.6 going to be released soon?

In the OpenRefine UI code, I only found 10 actual issues which broke either the code or the cypress tests, which resulted in 53 tests failing. In some cases, one bug broke multiple tests.

A lot of the changes were migrating deprecated functions, but of course that isn't required. JQuery has deprecated many functions, but they have been very slow to remove them. If you look at the list, they have only removed functions in early jQuery 1.3-1.10. (Ref: https://api.jquery.com/category/removed/). There were only a handful of places OpenRefine was using removed jQuery functions.

For extensions, I would expect there would be few issues. If there are popular extensions outside of this repo, link them here and I can try them out with OpenRefine 3.6 and jQuery 3.6.00 to see if they work.

And yes, the upgrade does resolve four security issues. Not sure how critical that is if OpenRefine is mainly used locally or within a private network. I've added info to the PR for that.

[wetneb]

Yes I would like to release 3.6 soon.
We have a list of popular extensions here: https://openrefine.org/download.html

[elebitzero]

I looked at the list of extensions but most were not active and haven't been updated to work with OpenRefine 3.5.x.

If we postpone upgrading jQuery, that means any new extensions on 3.6.x will be using jQuery 1.12.4, and may break when jQuery gets upgraded in the next OpenRefine version.

[wetneb]

Merging and adding to 3.6 since no concerns have been raised.