Added error messages for scatterplot facet - #4893
Merged
Merged
Conversation
… plot facet without the requisite columns.
wetneb
approved these changes
May 27, 2022
wetneb
left a comment
Member
There was a problem hiding this comment.
Works for me, leaving open for longer if people want to chime in.
Member
|
Looking at the code the test of whether a column is Numeric or not seems to be that more than half the values in the column are numeric. So two questions
|
Member
|
It is definitely not ideal to rely on such a threshold… I guess it would make sense to mention it in this error message indeed! |
Member
Author
|
I updated the error messages to mention the threshold, and I noticed the scatterplot documentation doesn't mention what a numeric column is: (Ref: https://docs.openrefine.org/manual/facets#scatterplot-facet). Scatterplot seems to be the only feature which uses the concept of a numeric column. Other features work on individual cells, like numeric facet. |
wetneb
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4890
Changes proposed in this pull request:
Let me know if the wording of the error message is alright:
When column is not numeric:
"Scatterplot requires a numeric column (green values). The column $1 has less than 50% numeric data. If a column has numerical data but is stored as text (black color), then use Column->Edit Cells->Common Transforms->to Number to convert."
When column is numeric, but there are no other numeric columns to compare against:
"No other numeric columns, (columns with more than 50% numeric data (green values)), to compare with Column $1."