Skip to content

Rearranged "Search for Match" dialog so the dropdown doesn't cover the buttons#4945

Merged
wetneb merged 1 commit intoOpenRefine:masterfrom
elebitzero:issue-4821-search-for-match-dialog-dropdown-fix
Jun 15, 2022
Merged

Rearranged "Search for Match" dialog so the dropdown doesn't cover the buttons#4945
wetneb merged 1 commit intoOpenRefine:masterfrom
elebitzero:issue-4821-search-for-match-dialog-dropdown-fix

Conversation

@elebitzero
Copy link
Member

Fixes #4821

Changes proposed in this pull request:

  • Rearranged "Search for Match" dialog so the dropdown doesn't cover the buttons.
  • Fixed escape key handling so hitting escape will close the dropdown without closing the dialog. To close the dialog hit escape again.

New layout:
search-for-match-new-layout

@github-actions github-actions bot added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. labels Jun 9, 2022
Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!
Leaving this open a bit longer to leave the opportunity for others to chime in.

@wetneb wetneb merged commit 5e698f2 into OpenRefine:master Jun 15, 2022
@elebitzero elebitzero deleted the issue-4821-search-for-match-dialog-dropdown-fix branch April 11, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Search for match' dialog: search dropdown mostly covers 'Don't reconcile cell' button, and fully covers 'Cancel' button

2 participants