Skip to content

Updated refine.bat to use %JAVA_HOME% and be consistent with the refine script #4949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2022
Merged

Updated refine.bat to use %JAVA_HOME% and be consistent with the refine script #4949

merged 1 commit into from
Jun 15, 2022

Conversation

elebitzero
Copy link
Member

Fixes #4930

Changes for refine.bat:

  • Only use java found in %JAVA_HOME% to check the version and run.
  • Exit if Java Release < 11
  • Warn if Java Release > 17

Changes for refine:

  • Exit if Java Release < 11

Running with Java 8:

>refine.bat run
Using refine.ini for configuration
Java 8 (1.8.0_332)
OpenRefine requires Java version 11 or later. If you have multiple versions of Java installed, please set the environment variable JAVA_HOME to the correct version.

Running with Java 17:

>refine.bat run
Using refine.ini for configuration
Java 17 (17.0.2)
Getting Free Ram...
23:47:36.994 [            refine_server] Starting Server bound to '[127.0.0.1:3333](http://127.0.0.1:3333/)' (0ms)

@github-actions github-actions bot added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. java version compatibility Making sure OpenRefine runs on as many Java versions as possible labels Jun 10, 2022
wetneb
wetneb approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Adding this to 3.6 as well.

@wetneb wetneb merged commit abab670 into OpenRefine:master Jun 15, 2022
wetneb pushed a commit that referenced this pull request Jun 15, 2022
@elebitzero @wetneb
Updated refine.bat to use %JAVA_HOME% and be consistent with the refi…
b90b08e 
…ne script. (#4949)
@wetneb wetneb added this to the 3.6 milestone Jun 15, 2022
@elebitzero elebitzero deleted the issue-4930-java-version-script-fix branch April 11, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetneb wetneb wetneb approved these changes

Assignees
No one assigned
Labels
java version compatibility Making sure OpenRefine runs on as many Java versions as possible Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

Java version messaging to users is inconsistent between Windows and Linux 'refine' scripts
2 participants
@elebitzero @wetneb