Added fix for Python preview expression error - #4991
Merged
wetneb merged 2 commits intoJun 27, 2022
Merged
Conversation
github-actions
Bot
added
Type: Bug
elebitzero
changed the title
wetneb
approved these changes
Jun 27, 2022
elebitzero
deleted the
issue-3012-python-preview-expression-error-handling
branch
April 11, 2023 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3012
I looked into this and found errors are being returned, but the Jython parser is return full exception traces instead of just reporting the error.
I have changed it to return
e.getMessage()instead ofe.toString()Msg Before:
Msg After:
AttributeError: 'com.google.refine.jython.JythonHasFieldsWrapper' object has no attribute 'a'Before:
After:
