Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed regression introduced from ellipsis update #5003

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fixed regression introduced from ellipsis update #5003

merged 1 commit into from
Jul 4, 2022

Conversation

elebitzero
Copy link
Member

Changes proposed in this pull request:

  • Fixed regression introduced from ellipsis update. Now the sort dropdown menu displays as it did in OR 3.5.2.

Before:
image

After:
image

wetneb
wetneb approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spurious CI failure.

@wetneb wetneb merged commit 8bfd28b into OpenRefine:master Jul 4, 2022
@wetneb wetneb added this to the 3.6 milestone Jul 4, 2022
@wetneb
Copy link
Member

wetneb commented Jul 4, 2022

Backporting to 3.6

wetneb pushed a commit that referenced this pull request Jul 5, 2022
@elebitzero @wetneb
Fixed regression introduced from ellipsis update. Now the sort dropdo…
af8693a 
…wn menu displays properly. (#5003)
@elebitzero elebitzero deleted the ellipsis-sort-text-regression-fix branch April 11, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetneb wetneb wetneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@elebitzero @wetneb