Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch URL throttle delay update #5188

Merged
merged 6 commits into from
Aug 17, 2022
Merged

Fetch URL throttle delay update #5188

merged 6 commits into from
Aug 17, 2022

Conversation

elebitzero
Copy link
Member

Fixes #5173

Changes proposed in this pull request:

  • Changed default throttle input delay for create column by fetching URLs to 500ms.
  • Added an error message for submitting a delay less than the minimum:
    image

@elebitzero
Changed default throttle input delay for create column by fetching ur…
fd9f68e 
…ls to 500ms and added an error message for submitting a delay less than the minimum.
@elebitzero
Cleanup.
5316328
@elebitzero
Cleanup.
7b89b01
@elebitzero
Cleanup.
1b5e0e3
@github-actions github-actions bot added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. fetch urls About fetching URLs in a project Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. labels Aug 16, 2022
thadguidry
thadguidry approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@thadguidry thadguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works as expected in Edge.

@wetneb wetneb merged commit 0664b1c into OpenRefine:master Aug 17, 2022
tfmorris
tfmorris reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@tfmorris tfmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in my comment on #5173, I don't think the 200ms minimum applies to the delay, but instead to the retry interval.

main/webapp/modules/core/langs/translation-en.json Show resolved Hide resolved
main/webapp/modules/core/scripts/views/data-table/menu-edit-column.js Show resolved Hide resolved
main/webapp/modules/core/scripts/views/data-table/menu-edit-column.js Show resolved Hide resolved
main/webapp/modules/core/scripts/views/data-table/add-column-by-fetching-urls-dialog.html
@@ -9,7 +9,7 @@
<td><input bind="columnNameInput" size="40" /></td>

<td width="1%" style="white-space: pre;" bind="or_views_throttle"></td>
<td><input bind="throttleDelayInput" size="10" value="5000" /> <span bind="or_views_milli"></span></td>
<td><input bind="throttleDelayInput" size="10" value="500" /> <span bind="or_views_milli"></span></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new default. That's always my starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfmorris tfmorris tfmorris left review comments

@thadguidry thadguidry thadguidry approved these changes

@ostephens ostephens Awaiting requested review from ostephens

Assignees
No one assigned
Labels
fetch urls About fetching URLs in a project Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is the 5000ms default delay for the fetch URL operation too high?
4 participants
@elebitzero @tfmorris @thadguidry @wetneb