Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL exporter UI consistency and improvements #5224

Merged
merged 3 commits into from
Sep 2, 2022
Merged

SQL exporter UI consistency and improvements #5224

merged 3 commits into from
Sep 2, 2022

Conversation

elebitzero
Copy link
Member

@elebitzero elebitzero commented Sep 1, 2022 •
edited
Loading

Changes proposed in this pull request:

  • Made the SQL exporter dialog labels more consistent with respect to capitalization, conciseness and grammar.
  • Cleaned up the checkbox behavior and styling on the download tab.
  • Changed the menu item names to be more consistent with the rest.

After:
SQL export UI improvements

Content After:
image

Download After:
image

Export Menu After:
exportMenuChanges

Custom Tabular Header After:
image

wetneb
wetneb approved these changes Sep 1, 2022
View reviewed changes
Copy link
Sponsor Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!!! Thank you so much!

@elebitzero elebitzero merged commit 051b25b into OpenRefine:master Sep 2, 2022
katrinleinweber pushed a commit to katrinleinweber/OpenRefine that referenced this pull request Sep 4, 2022
@elebitzero
SQL exporter UI consistency and improvements (OpenRefine#5224)
6c87bec 
* Cleaned up SQL exporter dialog.

* Cleaned up the SQL Export dialog style and made it more consistent.

* Fixed tests for Export -> SQL and Custom tabular.
@elebitzero elebitzero deleted the sql-exporter-ui-consistency-and-improvements branch April 11, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetneb wetneb wetneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elebitzero @wetneb