Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reconciliation dialog overflow issue. #5286

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

wetneb
Copy link
Member

@wetneb wetneb commented Sep 25, 2022

We plan to redesign this dialog completely - there are a lot of issues with it. This is just a fairly minimal fix to avoid its contents overflowing and hiding the "Reconcile" and "Cancel" buttons.

Closes #5285.

Changes proposed in this pull request:

  • make sure the lower part of the form can expand to the full width of the dialog by uncoupling it with the separation between the two upper parts
  • remove the (fairly arbitrary) height: 500px set on the dialog so that it can expand further down to fit its contents

New version:

image

We plan to redesign this dialog completely - there are a lot of issues with it.
This is just a fairly minimal fix to avoid its contents overflowing and hiding
the "Reconcile" and "Cancel" buttons.

Closes OpenRefine#5285.
@github-actions github-actions bot added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. reconciliation Related to the reconciliation operations and other features UX labels Sep 25, 2022
Copy link
Member

@elebitzero elebitzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wetneb

Looks good, except without width: 500px, when the reconcile dialog first opens the main panel is empty until you select a recon service, and it looks odd with the service dropdown menu extended outside the dialog, as seen below. I would change it to min-width: 500px.

(Only need to set min-width on recon-dialog-service-panel-container, not necessary for recon-dialog-service)

I noted on the issue that this is not a regression, but has been existing bug. If we will have a 3.6.2 patch, this is a good candidate.

image

@wetneb
Copy link
Member Author

wetneb commented Sep 26, 2022

Thanks a lot, I should have caught that…

@wetneb wetneb merged commit 28307f2 into OpenRefine:master Sep 26, 2022
wetneb added a commit that referenced this pull request Oct 3, 2022
* Fix recon dialog overflow issue.

We plan to redesign this dialog completely - there are a lot of issues with it.
This is just a fairly minimal fix to avoid its contents overflowing and hiding
the "Reconcile" and "Cancel" buttons.

Closes #5285.

* Add min-height to fix service selection issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reconciliation Related to the reconciliation operations and other features Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dysfunctional reconciliation dialog window in OpenRefine 3.7 snapshots (since around Sep 20, 2022)
2 participants