Update refine.bat #5404
Merged
Update refine.bat #5404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Read ini file" part should be above the "Check JAVA_HOME" part. In the refine.ini file a custom JAVA_HOME can be defined and if JAVA_HOME is checked before reading the ini file, the custom JAVA_HOME setting is never used.
github-actions
bot
added
Type: Bug
wetneb
reviewed
Nov 3, 2022
There was a problem hiding this comment.
Thank you for this, it makes sense to me! Can someone on Windows confirm, maybe @thadguidry?
thadguidry
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Read ini file" part should be above the "Check JAVA_HOME" part. In the refine.ini file a custom JAVA_HOME can be defined and if JAVA_HOME is checked before reading the ini file, the custom JAVA_HOME setting is never used.
Fixes #5384
Changes proposed in this pull request: