Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /Applications shortcut to macOS dmg file #5509

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Add /Applications shortcut to macOS dmg file #5509

merged 1 commit into from
Dec 8, 2022

Conversation

messense
Copy link
Contributor

@messense messense commented Dec 8, 2022

Fixes #5205

Changes proposed in this pull request:

  • Use dmgbuild to create macOS dmg file with a shortcut to /Applications and a simple arrow background (can be changed to something else if you design a better background image).

image

@github-actions github-actions bot added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Platform: macOS Denotes that the item is relevant to macOS users or macOS-specific environments packaging How we distribute OpenRefine to end users, on various operating systems labels Dec 8, 2022
@wetneb
Copy link
Sponsor Member

wetneb commented Dec 8, 2022

Thanks a lot for tackling this @messense!

I tried building the DMG with your new pipeline on Linux and was not sure if it would be supported. It did generate a DMG file, but the internal structure seems to be wrong (when opening the DMG in MacOS VM):
image

Since I am not getting the same result as you, I suspect this is just a consequence of the fact that I built on Linux?
In the CI, we are building with MacOS, so I would be tempted to just merge this and see if the DMG built by the CI works as expected.

@messense
Copy link
Contributor Author

messense commented Dec 8, 2022

I suspect this is just a consequence of the fact that I built on Linux?

I've only tested on arm64 macOS, looking at the CI configuration of dmgbuild they also only test on macOS: https://github.com/dmgbuild/dmgbuild/blob/main/.github/workflows/ci.yml

@messense
Copy link
Contributor Author

messense commented Dec 8, 2022

https://github.com/dmgbuild/mac_alias

While it is written in pure Python, some OS X specific code is required to generate a proper Alias or Bookmark record for a given file, so this module currently is not portable to other platforms.

I think because dmgbuild depends on mac_alias, it's also not portable to non-macOS platforms..

Copy link
Sponsor Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then let's just merge this and I'll check the output from the CI. Exciting!

@wetneb wetneb merged commit 5ba697a into OpenRefine:master Dec 8, 2022
@messense messense deleted the macos-dmg-shortcut branch December 8, 2022 11:28
@wetneb
Copy link
Sponsor Member

wetneb commented Dec 8, 2022

It works as expected. Thanks again! I have awarded the corresponding bounty to you on IssueHunt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging How we distribute OpenRefine to end users, on various operating systems Platform: macOS Denotes that the item is relevant to macOS users or macOS-specific environments Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Applications shortcut in MacOS dmg + potentially add a nice background [$250 bounty]
2 participants