Skip to content

Return error, not null, on bad URL. Fixes #6137. - #6141

Merged
wetneb merged 1 commit into
OpenRefine:masterfrom
tfmorris:6137-bad-url-error
Nov 6, 2023
Merged

Return error, not null, on bad URL. Fixes #6137.#6141
wetneb merged 1 commit into
OpenRefine:masterfrom
tfmorris:6137-bad-url-error

Conversation

@tfmorris

@tfmorris tfmorris commented Nov 5, 2023

Copy link
Copy Markdown
Member

Fixes #6137

Changes proposed in this pull request:

  • Instead of swallowing URL/URI syntax errors and returning null to the user, return an EvalError object with the message from the exception
  • change the test behavior to match

@github-actions github-actions Bot added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. fetch urls About fetching URLs in a project error handling Improving the ways errors are reported to users labels Nov 5, 2023
@wetneb
wetneb merged commit 8dcf89d into OpenRefine:master Nov 6, 2023
@tfmorris
tfmorris deleted the 6137-bad-url-error branch November 8, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

error handling Improving the ways errors are reported to users fetch urls About fetching URLs in a project Type: Bug Issues related to software defects or unexpected behavior, which require resolution.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Column by Fetching URL silently fails on malformed URLs

2 participants