Add missing space in "add column based on reconciled values" dialog#6151
Merged
Conversation
github-actions
Bot
added
Type: Bug
Contributor
Author
|
Attaching the screenshot of fixed dialiog: |
wetneb
reviewed
Nov 10, 2023
wetneb
left a comment
wetneb
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for tackling this! The visual aspect looks good to me.
| $('<a href="javascript:{}"></a>') | ||
| .text($.i18n('core-views/remove-prop')) | ||
| .addClass("action") | ||
| .css("margin-right", "5px") |
Member
There was a problem hiding this comment.
@Abbe98 does that look like the right approach to you? I generally try to avoid inline CSS but for a place like this I think it's probably fine?
wetneb
changed the title
wetneb
approved these changes
Nov 16, 2023
wetneb
pushed a commit
that referenced
this pull request
Nov 29, 2023
…6151) * fixes spaces missing issue * formatted extra line * reverting to older version --------- Co-authored-by: Srinath Kadam <srinathkadam@Srinaths-MacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6143
Changes proposed in this pull request:
This is my first Open Source Contribution. Please let me know if I need to follow any additional details/steps