New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controls with null header template #14

Merged
merged 2 commits into from Dec 25, 2017

Conversation

Projects
None yet
2 participants
@paavohuhtala
Collaborator

paavohuhtala commented Dec 25, 2017

(Based on #13)

Treat UI elements with null HeaderTemplate like ones set to "[NONE]"

Fixes crashes when viewing certain UI controls in the data viewer, such as the MOTD.

paavohuhtala added some commits Dec 25, 2017

Treat UI elements with null HeaderTemplate like ones set to "[NONE]"
Fixes crashes when viewing certain UI controls in the data viewer, such as the MOTD.
@paavohuhtala

This comment has been minimized.

Collaborator

paavohuhtala commented Dec 25, 2017

There are, obviously, alternative ways of implementing this. One way would be to handle this case directly in the parser, where "[NONE]" would be coerced to null, and we'd only check for null.

@tgjones tgjones merged commit 277dc91 into OpenSAGE:master Dec 25, 2017

@tgjones

This comment has been minimized.

Collaborator

tgjones commented Dec 25, 2017

Thank you!

@tgjones tgjones added this to the v0.1.0 milestone Apr 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment