New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for special registry key for Zero Hour, refactor installation location #15

Merged
merged 2 commits into from Dec 26, 2017

Conversation

Projects
None yet
2 participants
@paavohuhtala
Collaborator

paavohuhtala commented Dec 25, 2017

When installing an Origin copy of the Generals + Zero Hour bundle on my secondary workstation I found out that for some reason it uses a different registry key than my other computer for ZH. No idea why.

Since the alternative registry key requires some special handling, I implemented it and decided to move Zero Hour installation resolution to a different method entirely. As a bonus, a Generals installation is only resolved once for all possible Zero Hour installations.

@paavohuhtala paavohuhtala changed the title from Add support for special registry key for Zero Hour, refactor to Add support for special registry key for Zero Hour, refactor installation location Dec 25, 2017

@tgjones tgjones merged commit 7e5fd14 into OpenSAGE:master Dec 26, 2017

@tgjones

This comment has been minimized.

Collaborator

tgjones commented Dec 26, 2017

Nice, thank you. As you'll have spotted I did some special-case work on resolving ZH installations, but I missed the different registry key for Origin installations.

@paavohuhtala paavohuhtala deleted the paavohuhtala:handle-zero-hour-origin-version branch Jan 1, 2018

@tgjones tgjones added this to the v0.1.0 milestone Apr 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment