New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests for games you don't have installed #16

merged 2 commits into from Dec 26, 2017


None yet
2 participants
Copy link

paavohuhtala commented Dec 25, 2017

(Based on #15)

This PR implements a custom XUnit test discoverer, which filters the tests by the games you have installed. Tests that require a specific game can be tagged with [GameFact(SageGame.GameName)]. I haven't classified every test yet, but I can do that if required.

The motivation behind this is that it doesn't make much sense to run tests that couldn't possibly pass because of missing data files. It also documents in a neat, declarative way which tests require which games.

@tgjones tgjones merged commit 91dd563 into OpenSAGE:master Dec 26, 2017


This comment has been minimized.

Copy link

tgjones commented Dec 26, 2017

This is a neat idea - thanks! I'm going to modify it a bit to allow multiple games to be passed to GameFact(...), since (for example) the .apt tests should be run for both BFME I and II. But I can do that after merging.

@paavohuhtala paavohuhtala deleted the paavohuhtala:skip-irrelevant-tests branch Jan 1, 2018

@tgjones tgjones added this to the v0.1.0 milestone Apr 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment