New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear game systems' component lists on scene change #21

Merged
merged 1 commit into from Jan 1, 2018

Conversation

Projects
None yet
2 participants
@paavohuhtala
Copy link
Contributor

paavohuhtala commented Dec 30, 2017

Fixes #19 .

OnSceneChange is virtual so that systems can customise the behaviour it if necessary.

Clear game systems' component lists on scene change
Fixes #19 and improves performance for obivous reasons

@paavohuhtala paavohuhtala force-pushed the paavohuhtala:clear-systems-on-scene-change branch from 33558e7 to 7db305f Dec 30, 2017

@tgjones tgjones merged commit 8f544f0 into OpenSAGE:master Jan 1, 2018

@tgjones

This comment has been minimized.

Copy link
Collaborator

tgjones commented Jan 1, 2018

In theory, components are supposed to be removed when their parent entity is removed, and entities are supposed to be removed when the scene changes, but there's a bug which means not all descendant entities are removed. I'm going to refactor and fix that stuff soon, but for now this a good workaround, thank you!

@paavohuhtala paavohuhtala deleted the paavohuhtala:clear-systems-on-scene-change branch Jan 1, 2018

@tgjones tgjones added this to the v0.1.0 milestone Apr 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment