New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map object z positioning #23

Merged
merged 2 commits into from Jan 1, 2018

Conversation

Projects
None yet
3 participants
@paavohuhtala
Collaborator

paavohuhtala commented Dec 30, 2017

Fixes map object Z positioning by adding the height map value at current position to the object's Z position instead of ignoring it entirely.

Before:

image

After:

image

WorldBuilder for reference:

image

paavohuhtala added some commits Dec 30, 2017

Clear game systems' component lists on scene change
Fixes #19 and improves performance for obivous reasons
Add HeightMap height to map object's Z instead of replacing it
Object Z is relative to height map position.

Fixes various bits around the maps, such as mountain bunkers and drain pipes.
@feliwir

This comment has been minimized.

Collaborator

feliwir commented Dec 31, 2017

Looks really good to me

@tgjones tgjones merged commit 014d233 into OpenSAGE:master Jan 1, 2018

@tgjones

This comment has been minimized.

Collaborator

tgjones commented Jan 1, 2018

Nice, thank you!

@paavohuhtala paavohuhtala deleted the paavohuhtala:fix-map-object-z-positioning branch Jan 1, 2018

@tgjones tgjones added this to the v0.1.0 milestone Apr 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment