New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a project for the game executable #35

Merged
merged 4 commits into from Jan 5, 2018

Conversation

Projects
None yet
2 participants
@paavohuhtala
Copy link
Contributor

paavohuhtala commented Jan 3, 2018

Adds a new project for the game executable. It's Windows-only for now, so I named it OpenSAGE.Windows. It defaults to Generals and loads the main menu and the background scene.

The only change to the core engine is the addition of a HideImage property to UIElement, which is used to hide the background image in the main menu.

There's also an another patch coming related to WaypointPaths, which I used for the Twitter video.

@@ -145,6 +145,8 @@ public bool Highlighted
}
}

public bool HideImage { get; set; }

This comment has been minimized.

@tgjones

tgjones Jan 4, 2018

Collaborator

I'm pretty sure this is actually handled by the W3DNoDraw callback, as set in MainMenu.wnd, line 18. The only reason I didn't implement that yet is because it was nice to see the backdrop image - but now that you're starting to add the actual shell map, we can go ahead and implement W3DNoDraw in the WndCallbacks class.

@paavohuhtala paavohuhtala referenced this pull request Jan 4, 2018

Merged

Scripting improvements #37

@paavohuhtala paavohuhtala force-pushed the paavohuhtala:game-executable branch from f7f3a87 to 5b7e4de Jan 4, 2018

@tgjones

This comment has been minimized.

Copy link
Collaborator

tgjones commented Jan 5, 2018

I think the launcher project should be named OpenSage.Launcher.Windows”, to make its purpose clearer. Would you mind making that change? Then I think this is good to be merged.

@paavohuhtala

This comment has been minimized.

Copy link
Contributor

paavohuhtala commented Jan 5, 2018

@tgjones Renamed.

@tgjones tgjones merged commit 3e76658 into OpenSAGE:master Jan 5, 2018

@tgjones

This comment has been minimized.

Copy link
Collaborator

tgjones commented Jan 5, 2018

Thanks!

@paavohuhtala paavohuhtala deleted the paavohuhtala:game-executable branch Jan 5, 2018

@tgjones tgjones added this to the v0.1.0 milestone Apr 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment