EstEID ECDSA token support #1158
Merged
Conversation
Signed-off-by: Raul Metsma <raul@metsma.ee>
src/libopensc/card-mcrd.c
Outdated
| flags = SC_ALGORITHM_ECDSA_RAW | SC_ALGORITHM_ECDH_CDH_RAW | SC_ALGORITHM_ECDSA_HASH_NONE; | ||
| ext_flags = SC_ALGORITHM_EXT_EC_NAMEDCURVE | SC_ALGORITHM_EXT_EC_UNCOMPRESES; | ||
| _sc_card_add_ec_alg(card, 256, flags, ext_flags, NULL); | ||
| _sc_card_add_ec_alg(card, 384, flags, ext_flags, NULL); |
martinpaljak
Sep 27, 2017
Member
Just a single algorithm is supported.
Just a single algorithm is supported.
src/libopensc/pkcs15-esteid.c
Outdated
| static const char *prkey_name[2] = { | ||
| "Isikutuvastus", | ||
| "Allkirjastamine"}; | ||
|
|
||
| struct sc_pkcs15_prkey_info prkey_info; | ||
| struct sc_pkcs15_object prkey_obj; | ||
|
|
||
| if (field_length == 0) |
martinpaljak
Sep 27, 2017
Member
Maybe move the usages above to a single if-then-else statement, to keep them all together.
Maybe move the usages above to a single if-then-else statement, to keep them all together.
src/libopensc/pkcs15-esteid.c
Outdated
| prkey_info.modulus_length = 2048; | ||
| else | ||
| prkey_info.modulus_length = 1024; | ||
| prkey_info.modulus_length = 1024; |
martinpaljak
Sep 27, 2017
Member
1024b key cards are all gone now, support for older cards can be removed.
1024b key cards are all gone now, support for older cards can be removed.
metsma
Sep 27, 2017
Author
Contributor
This is only ECDSA supprt, cleanup can be done separate PR
This is only ECDSA supprt, cleanup can be done separate PR
Signed-off-by: Raul Metsma <raul@metsma.ee>
Signed-off-by: Raul Metsma <raul@metsma.ee>
|
@martinpaljak, I think all your comments have been considered and the code has been fixed. I think this can be merged, right? |
metsma
added a commit
to metsma/OpenSC
that referenced
this pull request
Nov 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Signed-off-by: Raul Metsma raul@metsma.ee
Checklist