Handle reader going missing #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Argh. It seems I used an out of date |
CendioOssman
force-pushed
the
noreader
branch
2 times, most recently
from
5ecfdde
to
3becee0
Compare
frankmorgner
approved these changes
Feb 28, 2019
plaes
reviewed
Mar 1, 2019
It might just be this specific reader going missing, and not all of them.
Older PC/SC doesn't have the code SCARD_E_NO_READERS_AVAILABLE, so fix the code to handle such systems as well.
The code already removes all active cards when the service goes away, but it doesn't remove the reader. This can be a bit confusing since they will still be polled and listed.
|
We found some more issues on this theme when we did further testing, so I'd like to suggest these two commits as well. |
frankmorgner
approved these changes
Mar 3, 2019
|
Thanks, these look like useful fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we report properly to the upper layers if PC/SC is reporting that the reader has gone missing. Otherwise applications won't be properly notified that something has happened.
Checklist