pkcs15init: correct left length calculation to fix buffer overrun bug. #2787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2785
This PR aims to fix the buffer overrun vulnerability in src/pkcs15init/pkcs15-cardos.c, which falsely calculated the length of left bytes in buffer while looking for 2 specific tags in buffer.
This is a recurring bug as one occurence of GHSA-xq25-8g7f-6hc5, and the fix commit is almost the same.