Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uppkcs11-tool: various improvements: extensions, bug fixes, and cleanup #747
Conversation
This comment has been minimized.
This comment has been minimized.
your code does not compile, see the CI links above |
… (corrections w.r.t. #ifdef ENABLE_OPENSSL)
This comment has been minimized.
This comment has been minimized.
So far I had thought the partial failures of the automated builds were due to unrelated architecture issues. Yet I just found that the code did not compile in case |
This comment has been minimized.
This comment has been minimized.
please split your commits into smaller ones with changes that logically belong together and fix your commit message with a summary of those changes. Review and rollback in case of problem is much easier in small chunks! |
This comment has been minimized.
This comment has been minimized.
there is more, see for example https://travis-ci.org/OpenSC/OpenSC/jobs/127526153#L1263 |
This comment has been minimized.
This comment has been minimized.
Thanks @frankmorgner for your hint on a point where the compilation went wrong. After two more iterations, where I corrected two further problems with conditional compilation (this time related to the definedness of The Travis Cl build confirms this, while the AppVeyor build still has some trouble related to |
This comment has been minimized.
This comment has been minimized.
CI is good now, but I fear you'll have to split up the commits... |
This comment has been minimized.
This comment has been minimized.
@DDvO did you make any progress? without the splitup we can't review your changes |
This comment has been minimized.
This comment has been minimized.
Thanks for asking. I cannot spend much further time on it, but will try to do soon. BTW, my motivation to contribute to this project dropped a lot after my frustrating #737 experience. |
======================================== rebased by VTA -- commits are forged to one, excluding the following chunk (reason -- if not explicitely indicated, the mechanism has to be found out using the mechanism flags): @@ -1713,8 +1713,9 @@ static int gen_keypair(CK_SLOT_ID slot, CK_SESSION_HANDLE session, int ii; if (!opt_mechanism_used) + opt_mechanism = CKM_EC_KEY_PAIR_GEN; if (!find_mechanism(slot, CKF_GENERATE_KEY_PAIR, mtypes, mtypes_num, &opt_mechanism)) - util_fatal("Generate EC key mechanism not supported\n"); + util_warn("Generate EC key mechanism not listed as supported"); for (ii=0; ec_curve_infos[ii].name; ii++) { if (!strcmp(ec_curve_infos[ii].name, type + 3)) will close PR #747
This comment has been minimized.
This comment has been minimized.
essential part applied in 4441efa, |
DDvO commentedApr 27, 2016
•
edited
This is a collection of improvements I recently implemented on pkcs11-tool and would like to share for the benefit of other users:
parse_ec_pkey()
test_kpgen_certwrite()
hex_to_bin()
input and outputdo_read_key()
RSA_GET_BN()
macrowrite_object()
I am aware that this sums up to quite a number of items, where some 170 lines have been changed and about 230 lines have been added. Yet it would be pretty time consuming to break this up into many per-topic pull requests, while this overhead would not add anything in terms of productivity.
All changes, and I hope also all additions, should be pretty straightforward to understand
So please have a look and take over whatever you consider useful. I am available for answering any questions and comments.